Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTML Validator errors for templates #2798

Closed
4 of 47 tasks
koderjoker opened this issue Jan 1, 2020 · 10 comments · Fixed by #4153, #4154, #4155, #4157 or #4158
Closed
4 of 47 tasks

Fix HTML Validator errors for templates #2798

koderjoker opened this issue Jan 1, 2020 · 10 comments · Fixed by #4153, #4154, #4155, #4157 or #4158
Assignees
@koderjoker
Labels
Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] State: Work In Progress This issue is being actively worked on. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Bug Something isn't working. [managed]

Comments

@koderjoker
Copy link
Contributor

koderjoker commented Jan 1, 2020 •
edited
Loading

Child issue of #163. Aims to resolve all HTML validation issues associated with templates.

Related files

Folders

  • account
  • authors
  • books
  • contact
  • covers
  • email
  • history
  • home
  • languages
  • lib
  • libraries
  • lists
  • merge
  • publishers
  • recentchanges
  • search
  • site
  • stats
  • subjects
  • type
  • work

Files

  • account.html
  • borrow_admin.html
  • borrow_admin_no_update.html [IN PROGRESS]
  • design.html
  • diff.html
  • edit_yaml.html
  • editpage.html
  • form.html
  • history.html
  • internalerror.html
  • login.html
  • message.html
  • messages.html
  • notfound.html
  • permission.html
  • permission_denied.html
  • showamazon.html
  • showia.html
  • showmarc.html
  • site.html
  • status.html
  • subjects.html
  • support.html
  • viewpage.html
  • widget.html
  • work_search.html

Stakeholders

@jdlrobson @mekarpeles @koderjoker
@koderjoker koderjoker added Affects: Admin/Maintenance Issues relating to support scripts, bots, cron jobs and admin web pages. [managed] 1-off tasks accounts Affects: Data Issues that affect book/author metadata or user/account data. [managed] Affects: Configuration Related to the configuration of the dev/staging/prod environments, CI, docker, etc. [managed] State: Work In Progress This issue is being actively worked on. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Bug Something isn't working. [managed] and removed 1-off tasks Affects: Admin/Maintenance Issues relating to support scripts, bots, cron jobs and admin web pages. [managed] Affects: Configuration Related to the configuration of the dev/staging/prod environments, CI, docker, etc. [managed] Affects: Data Issues that affect book/author metadata or user/account data. [managed] accounts labels Jan 1, 2020
@koderjoker koderjoker self-assigned this Jan 1, 2020
@koderjoker koderjoker mentioned this issue Jan 2, 2020
Merged
2 tasks
@xayhewalo xayhewalo added the Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] label Jan 3, 2020
@jdlrobson jdlrobson added the Priority: 3 Issues that we can consider at our leisure. [managed] label Jan 5, 2020
@Castella1313
Copy link
Contributor

working on part of this issue under the guidance of @koderjoker

1 similar comment
@Abhir-24
Copy link

working on part of this issue under the guidance of @koderjoker

This was referenced Feb 3, 2020
Merged
Merged
@aashimgarg aashimgarg mentioned this issue Feb 4, 2020
Merged
This was referenced Oct 5, 2020
Closed
Closed
@navneetsaluja navneetsaluja mentioned this issue Oct 20, 2020
Merged
@cclauss
Copy link
Contributor

cclauss commented Oct 26, 2020

Could we please get an update on this issue?

This was referenced Oct 30, 2020
Closed
Closed
@ArunTeltia ArunTeltia mentioned this issue Nov 25, 2020
Merged
This was referenced Nov 25, 2020
Merged
Merged
Merged
Merged
@cclauss
Copy link
Contributor

cclauss commented Nov 26, 2020

Reopening. The trigger at #4153 (comment) closed this issue but I do not believe this issue is completely resolved.

@cclauss cclauss reopened this Nov 26, 2020
@ArunTeltia
Copy link
Contributor

This issue has a lot of things that need to be manually checked and I am currently looking for it right now

@ArunTeltia ArunTeltia mentioned this issue Dec 1, 2020
Merged
@cdrini cdrini reopened this Dec 14, 2020
@ArunTeltia ArunTeltia mentioned this issue Dec 16, 2020
Closed
@jdlrobson
Copy link
Collaborator

This issue is a bit too broad for me and I find big tasks don't lend well to volunteers and many of those templates are used on multiple pages. Would be better to create issues for every single page, as we encounter them. Also, some of these pages are more often used than others. For example, fixing stats would be a super low priority.

Going through the list of pages using those templates I've created the following issues for the important ones:
#4438
#4439
#4440
#4441

@ArunTeltia
Copy link
Contributor

@jdlrobson i was working in this last month then I got covid so I was not able to work on it, will get start with this by next week
It will be my first priority sorry for the delay

@jdlrobson
Copy link
Collaborator

No problem and no rush. I think it makes more sense to focus on pages rather than templates. The goal is still the same.

Hope you are feeling a lot better now!

@mekarpeles
Copy link
Member

@ArunTeltia I hope you are feeling better ☹️

@ArunTeltia
Copy link
Contributor

Yes sir I am thank you, will start the work real soon ☺️

@ArunTeltia ArunTeltia mentioned this issue Feb 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koderjoker koderjoker

Labels
Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] State: Work In Progress This issue is being actively worked on. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
9 participants
@jdlrobson @mekarpeles @cclauss @cdrini @xayhewalo @koderjoker @ArunTeltia @Castella1313 @Abhir-24