Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking commit of manually checking HTML_Validation #4153

Merged
merged 1 commit into from
Nov 26, 2020
Merged

breaking commit of manually checking HTML_Validation #4153

merged 1 commit into from
Nov 26, 2020

Conversation

ArunTeltia
Copy link
Contributor

@ArunTeltia ArunTeltia commented Nov 25, 2020 •
edited
Loading

Breaking #3977 that Partially resolve #2798

cdrini
cdrini approved these changes Nov 26, 2020
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Not testing this since the changes are trivial. Note we should be able to delete RecentPageList; it looks unused! I created an issue for us to do that: #4167

@cdrini cdrini self-assigned this Nov 26, 2020
@cdrini cdrini merged commit 9df9e85 into internetarchive:master Nov 26, 2020
@cclauss cclauss mentioned this pull request Nov 26, 2020
Closed
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrini cdrini cdrini approved these changes

Assignees

@cdrini cdrini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix HTML Validator errors for templates
2 participants
@ArunTeltia @cdrini