-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some tags did not have closing tags and indentation was not proper in this file #2969
Conversation
@jdlrobson is it okay? |
I was hoping you could reassure me. Haven't looked at these pages before. :) Can you post some screenshots? |
These are the web.py templates for the frontend. |
I understand what you are doing. What I don't understand is what the content after "Prolific Member Editors" does and why you need to change the markup there. Are you able to get this to display locally? |
I changed the markup because as href attribute of the anchor tag in html --> href="_" encloses the link in the double codes. |
Please post a screenshot. |
Thanks @aashimgarg |
@aashimgarg @jdlrobson I chose to merge this without the screenshots as this is dead-code (unfortunately) and I don't believe you could view this page properly with the current site config. @jdlrobson was right to ask for screenshots, testing page changes in your local env is always the right thing to do, and we all would have noticed sooner that this page isn't used and can't be viewed :) I will be adding an issue to investigate some of these unused admin templates so they can be removed. |
Issue solved #2798
Fixes HTML validation issues in
openlibrary/admin/templates/admin/index.html
Issues:
What is done:
1.Made the indentation proper. (as now it is much easier to understand)
2. gave the closing tags.
Stakeholders:
@koderjoker