Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replacing html valign with css vertical-align #2961

Merged
merged 1 commit into from
Feb 4, 2020
Merged

replacing html valign with css vertical-align #2961

merged 1 commit into from
Feb 4, 2020

Conversation

Castella1313
Copy link
Contributor

@Castella1313 Castella1313 commented Feb 3, 2020 •
edited
Loading

Issue solved #2798

Fixes HTML validation issues in
openlibrary/templates/history.html

Proposed:

Replace HTML valign with CSS vertical-align
Stakeholder
@koderjoker

@koderjoker koderjoker self-requested a review February 4, 2020 12:20
koderjoker
koderjoker approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@koderjoker koderjoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this pr

@koderjoker
Copy link
Contributor

@jdlrobson @mekarpeles

@jdlrobson
Copy link
Collaborator

Ideally we should aim to get these into a stylesheet but I think this is a useful interim step in that direction. Thank you.

@jdlrobson jdlrobson merged commit 5ca7c76 into internetarchive:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koderjoker koderjoker koderjoker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Castella1313 @koderjoker @jdlrobson