Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Individual Subject Page Images for Accessibility #4632

Closed
bpmcneilly opened this issue Feb 19, 2021 · 3 comments · Fixed by #4651
Closed

Testing Individual Subject Page Images for Accessibility #4632

bpmcneilly opened this issue Feb 19, 2021 · 3 comments · Fixed by #4651
Assignees
Labels
Theme: Accessibility Work related to disability accessibility. [managed]

Comments

@bpmcneilly
Copy link
Contributor

Page to Test:

Subjects - https://openlibrary.org/subjects/architecture

Steps

Steps for this task are outlined in #4521

Expectations

Test the specified page according to the steps outlined in the parent issue. Create individual bugs with steps to reproduce for any found violations on this page. Reference those bugs on this tracking issue.

Once the page has been tested & all bugs are found, close this issue.

@bpmcneilly bpmcneilly added the Theme: Accessibility Work related to disability accessibility. [managed] label Feb 19, 2021
@SaravgiYash
Copy link
Contributor

@bpmcneilly I would like to work on this.

@SaravgiYash
Copy link
Contributor

@bpmcneilly There is no alt attribute for book covers on this page as well as all other pages.
alt for lists present in widget-lists-wrapper is broken
image

@bpmcneilly
Copy link
Contributor Author

@Yashs911 I think the solution for the list images here will be similar to what we were discussing in #4633 - though it looks like the CSS might be slightly more challenging here.

for the carousels, it looks like we're gonna need the title attributes to become alt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Theme: Accessibility Work related to disability accessibility. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants