Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Images for Accessibility #4521

Open
20 tasks done
bpmcneilly opened this issue Feb 2, 2021 · 13 comments
Open
20 tasks done

Test Images for Accessibility #4521

bpmcneilly opened this issue Feb 2, 2021 · 13 comments
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Accessibility Work related to disability accessibility. [managed] Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed]

Comments

@bpmcneilly
Copy link
Contributor

bpmcneilly commented Feb 2, 2021

Help us make sure all of the Open Library images are accessible to our users!

For this task, we want you to take a look through the images on Open Library & make sure they have appropriate alternatives for screen reader users.

Steps

  1. Go through each of the pages under the 'Pages to Test' heading
    1. If you can't take on every page, no worries! Just add a comment here & let us know what pages you're reviewing ☺️
  2. Every time you encounter an image on a page, look at the underlying HTML code
    1. If the image is an inline img element:
      1. Make sure the element has an alt attribute
      2. If the image adds meaning to the page, make sure the alt value represents the meaning the image adds
      3. If the image is purely decorative (e.g. if it adds a background color or shading, or does not supply "content") make sure the alt attribute is null (i.e. alt="")
    2. If the image is implemented with CSS (e.g. through the background-image property):
      1. Make sure the image is purely decorative
  3. If any of the steps above do not pass, please file a bug (or better yet a PR!) related to this image
    1. General bug / PR formatting is available on the main Accessibility Issue: Site Accessibility Review & Implementation #4202
    2. For image issues / PRs, make sure you include what the current alternative is (if any) & what you think the alternative should be!

Resources

  • If you're asking yourself, "Is this image decorative?" or "Does this alt attribute really represent what this image shows visually?", take a look at this article from WebAIM about Alternative Text
  • If the image you're investigating is implemented in another way (e.g. an SVG icon, something implemented with the CSS content property, or something more elusive) feel free to flag us if you know how alternatives work for this image type. Otherwise, reach out to the accessibility contact!

Pages to test

@bpmcneilly bpmcneilly added Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Feb 2, 2021
@bpmcneilly bpmcneilly added Lead: @bpmcneilly Issues overseen by Brian (Accessibility Lead) [managed] Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Theme: Accessibility Work related to disability accessibility. [managed] and removed Needs: Lead Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Feb 2, 2021
@Sabreen-Parveen
Copy link
Collaborator

@bpmcneilly I would like to work on this issue.

@nynaalekhya
Copy link
Contributor

@bpmcneilly Can I work on this issue

@SaravgiYash
Copy link
Contributor

SaravgiYash commented Feb 3, 2021

@bpmcneilly I would like to work on Lists Page

@Sabreen-Parveen This particular issue involves many pages you can select one page at a time and start working on that particular page. Other contributors can also do the same. So that others don't get alienated from contributing. :)

@Sabreen-Parveen
Copy link
Collaborator

Sabreen-Parveen commented Feb 3, 2021

I have noticed that the footer Internet Archive logo, has an alt attribute and it's null, Should I change it to Internet Archive logo?
image

@Sabreen-Parveen
Copy link
Collaborator

Sabreen-Parveen commented Feb 3, 2021

I have checked the login page and Subjects Page, we do not need to make any changes in them.

@nynaalekhya
Copy link
Contributor

nynaalekhya commented Feb 3, 2021

@bpmcneilly I would like to work on Book page and Search Results page

@bpmcneilly
Copy link
Contributor Author

@Yashs911 Let me know when the lists page is done!
@Sabreen-Parveen Thanks for those two confirmations on the login & subjects page! Let me know if there are any others you plan on taking a look at.
Regarding the footer, I think this is an instance where a null attribute is appropriate - the logo is there, but without the logo we get all the same information because the text after reads "Open Library is an initiative of the Internet Archive...".
@nynaalekhya Awesome, let me know when you've taken a look & if there are any issues!

I think our checklist is all up to date with all of our progress so far!

@Sabreen-Parveen
Copy link
Collaborator

Want to read , Report a problem pages are good to go, found no issues on them.

@dwaipayan05
Copy link
Contributor

dwaipayan05 commented Feb 12, 2021

I'd be reviewing Recent Changes

Edit :- Recent Changes seems fine, no changes required.

@SaravgiYash
Copy link
Contributor

SaravgiYash commented Feb 19, 2021

@bpmcneilly I would like to work on Lists Page

@bpmcneilly I went through the list page and I noticed that the cover image for a list is a book cover of the book present in that list but the alt attribute says alt="Cover of: integrity books(list name)" which is technically wrong.
image
image

@bpmcneilly
Copy link
Contributor Author

Hey everyone, I converted the list to a series of tasks so we can keep discussions relevant to only a single page there, rather than clutter this larger issue. Feel free to assign yourselves to any of the other pages you're currently testing, and any questions you have have!

@melissa-tan10
Copy link

melissa-tan10 commented Mar 5, 2021

I can work on Testing Library Explorer Images for Accessibility #4640

@mekarpeles mekarpeles added the Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] label Sep 15, 2023
Copy link

Assignees removed automatically after 14 days.

@jimchamp jimchamp added Priority: 3 Issues that we can consider at our leisure. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] and removed Lead: @bpmcneilly Issues overseen by Brian (Accessibility Lead) [managed] labels Jan 25, 2024
@mekarpeles mekarpeles removed the Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Accessibility Work related to disability accessibility. [managed] Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed]
Projects
None yet
Development

No branches or pull requests

8 participants