Added Missing Alt Value for Footer Archive Logo #4585
Conversation
dwaipayan05
changed the title
|
Not an issue according to @bpmcneilly (#4521 (comment)) |
what about people using screen readers? |
| @@ -50,7 +50,7 @@ <h2>$:_('Help')</h2> | |||
| </div> | |||
| <hr> | |||
| <div id="footer-details"> | |||
| <img id="archive-logo" src="/static/images/pantheon.png" alt="" aria-hidden="true"> | |||
| <img id="archive-logo" src="/static/images/pantheon.png" alt="Archive Logo" aria-hidden="true"> | |||
There was a problem hiding this comment.
Internet Archive Logo or archive.org logo might be more appropriate here. Will someone using a screenreader know what "Archive" means?
There was a problem hiding this comment.
Would "Internet Archive Logo" work ?
There was a problem hiding this comment.
Note, best to wait for @bpmcneilly though as this answer may change :)
Sorry sent early before I could finish my longer reply. Expanding on this I'm super curious @bpmcneilly on your answer there. I can understand it's not necessary given the text to the right, but it's focusable so if I was using a screen-reader and focused on the image, I would be told there's no alternate text or the filename would be recited and I perhaps would have no idea what I'm looking at. Wouldn't an explict empty alt tag be better there, so I know it's intentionally been removed? Have recommendations changed since https://www.w3.org/WAI/tutorials/images/decorative/ ? |
There was a problem hiding this comment.
Merge pending whether @bpmcneilly says an empty alt is preferred here.
|
Now I feel a bit stupid.. looks like we already had the explicit empty alt value (I'm not sure where I got the idea we had no alt attribute at all, which makes sense given #4521 (comment) As a result there is no reason to change the status quo. Hope that makes sense @dwaipayan05 - let me know if you need any explanation of the above link! |
|
Sorry for the delay in responding to this, @jdlrobson! For posterity, I'll also add an additional note on images - decorative images (discussed in the W3C link above) can just have null |
No worries - I managed to confuse myself, and originally thought we were omiting the alt tag entirely, but what you write here is consistent with my understanding of how this should all work, so thanks for the reassurance/knowledge refresher. :) Glad to have you looking at this codebase! |
Closes #4584
Added a missing Alt Value for the Footer Archive Logo