Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Lists" link to books page navbar #6096

Closed
jimchamp opened this issue Feb 3, 2022 · 2 comments · Fixed by #6104
Closed

Add "Lists" link to books page navbar #6096

jimchamp opened this issue Feb 3, 2022 · 2 comments · Fixed by #6104
Assignees
@homewardgamer
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Book Page Issues related to the redesign of the books page Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed]

Comments

@jimchamp
Copy link
Collaborator

jimchamp commented Feb 3, 2022

Describe the problem that you'd like solved

When visiting a books page, I have to scroll to nearly the bottom of the page to see the lists that contain the book. It would be great if I could jump to that section by clicking a link on the navbar.

Proposal & Constraints

Add a new link to the book page navbar that will jump to the "Lists containing this Book" section of the page. A unique id will need to be added to that section. Ensure that the new id is written in kebab-case, if necessary.

The text for the link should be "Lists", and it should be internationalized. The new link should appear rightmost on the navbar.

Additional context

Stakeholders
@jimchamp jimchamp added Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Feb 3, 2022
@jimchamp
Copy link
Collaborator Author

jimchamp commented Feb 3, 2022

@homewardgamer would you be interested in working on this?

@jimchamp jimchamp added Theme: Book Page Issues related to the redesign of the books page Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Feb 3, 2022
@jimchamp jimchamp mentioned this issue Feb 3, 2022
Closed
8 tasks
@homewardgamer
Copy link
Contributor

Yes @jimchamp I would love to work on this Issue! Thanks for considering me.

@homewardgamer homewardgamer mentioned this issue Feb 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@homewardgamer homewardgamer

Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Book Page Issues related to the redesign of the books page Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Lists link to books page navbar homewardgamer/openlibrary
2 participants
@jimchamp @homewardgamer