Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Lists link to books page navbar #6104

Merged
merged 3 commits into from
Feb 4, 2022

Conversation

homewardgamer
Copy link
Contributor

@homewardgamer homewardgamer commented Feb 3, 2022

Closes #6096

Added Lists link to books page navbar after the Reviews link.

Technical

Added the id lists to the Lists containing this Book section.

Testing

Screenshot

Screenshot 2022-02-03 at 12 21 47 PM

Stakeholders

@jimchamp @mekarpeles

@jimchamp jimchamp self-assigned this Feb 3, 2022
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this once the ID has been updated.

openlibrary/templates/type/edition/view.html Outdated Show resolved Hide resolved
@homewardgamer
Copy link
Contributor Author

@jimchamp Changed the id name to lists-section.

Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@jimchamp jimchamp merged commit 3027331 into internetarchive:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Lists" link to books page navbar
3 participants