Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

availability.js getUsersLoansAndWaitlists should be rolled back #736

Closed
mekarpeles opened this issue Jan 10, 2018 · 1 comment
Closed

availability.js getUsersLoansAndWaitlists should be rolled back #736

mekarpeles opened this issue Jan 10, 2018 · 1 comment
Assignees
@mekarpeles
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Theme: Performance Issues related to UI or Server performance. [managed]

Comments

@mekarpeles
Copy link
Member

A feature was started in availability.js which fetches a user's active waitlists to be used when checking getAvailabilityV2 -- getUsersLoansAndWaitlists. This method is incomplete and should be rolled back and moved to its own branch (until correctly implemented, it just negatively impacts performance)
@mekarpeles mekarpeles added blocker Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Theme: Performance Issues related to UI or Server performance. [managed] labels Jan 10, 2018
@mekarpeles mekarpeles self-assigned this Jan 10, 2018
@mekarpeles
Copy link
Member Author

Code will be removed in #734 734/refactor/readling-log-cleanup and migrated to `736/feature/detect-and-manage-waitlists

mekarpeles added a commit that referenced this issue Jan 10, 2018
@mekarpeles
Addressing #736, rolling back premature waitlist-checking change
9291176
mekarpeles added a commit that referenced this issue Jan 14, 2018
@mekarpeles
Addressing #736, rolling back premature waitlist-checking change
e248802
@brad2014 brad2014 added the Good First Issue Easy issue. Good for newcomers. [managed] label Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mekarpeles mekarpeles

Labels
Good First Issue Easy issue. Good for newcomers. [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Theme: Performance Issues related to UI or Server performance. [managed]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mekarpeles @brad2014