Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add history link to redirects noted in _compare diff #7509

Closed
Tracked by #7684
seabelis opened this issue Feb 7, 2023 · 2 comments · Fixed by #10155
Closed
Tracked by #7684

Add history link to redirects noted in _compare diff #7509

seabelis opened this issue Feb 7, 2023 · 2 comments · Fixed by #10155
Assignees
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 2 Important, as time permits. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@seabelis
Copy link
Collaborator

seabelis commented Feb 7, 2023

When tracing back possible merge errors, or temporarily reverting merges to unblock other reversions, I sometimes need to revert a redirect. Currently the process is to right-click, copy the original work url, paste it into a browser, and add ?m=history. This is tedious when there are many to check. A link to the history would be tremendously helpful.

Describe the problem that you'd like solved

Add a link to version histories from the compare diff views where linked items (typically authors and works) are noted.

Proposal & Constraints

A similar implementation exists when viewing an author merge. https://openlibrary.org/recentchanges/2021/08/31/merge-authors/84543795.

Additional context

Ex, https://openlibrary.org/books/OL24738846M/Slammerkin?_compare=Compare&b=5&a=2&m=diff is an edition history diff view. The edition has been moved from one work ID to another. Having a link to the histories of those work IDs would save a lot of unnecessary typing. Likewise for any authors that would potentially appear there.
Screenshot 2023-02-07 at 09 34 07

Stakeholders

@mekarpeles @cdrini @jimchamp

@seabelis seabelis added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Affects: Librarians Issues related to features that librarians particularly need. [managed] Needs: Lead labels Feb 7, 2023
@seabelis seabelis self-assigned this Feb 7, 2023
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Lead: @mheiman and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Feb 13, 2023
@mekarpeles
Copy link
Member

mekarpeles commented Feb 13, 2023

The ask is to modify the Diff page to provide an additional link to go to the history page for a work (of type `redirect) instead of a work url which redirects the librarian

@jimchamp jimchamp mentioned this issue Mar 22, 2023
35 tasks
@jimchamp jimchamp added the Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] label Mar 28, 2023
@mekarpeles mekarpeles added Priority: 2 Important, as time permits. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] and removed Priority: 3 Issues that we can consider at our leisure. [managed] Lead: @mheiman labels Sep 15, 2023
@mekarpeles
Copy link
Member

Priority increased based on @seabelis feedback

@mekarpeles mekarpeles added this to the 2023 milestone Sep 15, 2023
@mekarpeles mekarpeles added Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] and removed Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] labels Oct 18, 2023
@RayBB RayBB added Good First Issue Easy issue. Good for newcomers. [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] labels Dec 10, 2024
@RayBB RayBB added Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. and removed Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 2 Important, as time permits. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants