Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add diff history links #10155

Merged
merged 1 commit into from
Dec 17, 2024
Merged

add diff history links #10155

merged 1 commit into from
Dec 17, 2024

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Dec 17, 2024

Closes #7509

Technical

Follows the style of the diff button on the author merge page here.
https://openlibrary.org/recentchanges/2021/08/31/merge-authors/84543795
But don't feel strongly about the style.

Testing

Merge two works then view the diff of an edition of the work like this:
http://localhost:8080/books/OL669819M/Creepy_Classics_II?_compare=Compare&b=2&a=1&m=diff

Screenshot

CleanShot 2024-12-17 at 13 37 54@2x

Stakeholders

@seabelis

@RayBB RayBB added Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. labels Dec 17, 2024
@mekarpeles mekarpeles merged commit c365481 into master Dec 17, 2024
6 checks passed
@mekarpeles mekarpeles deleted the diff-history-links branch December 17, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add history link to redirects noted in _compare diff
2 participants