Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drop shadow to cover modal #8868

Closed
RayBB opened this issue Mar 5, 2024 · 3 comments · Fixed by #8870
Closed

Add drop shadow to cover modal #8868

RayBB opened this issue Mar 5, 2024 · 3 comments · Fixed by #8870
Assignees
@QuantuM410
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Mar 5, 2024 •
edited
Loading

Describe the problem that you'd like solved

It would be nice if the cover shown in the cover modal had a dropshadow (border) like it does most places. You can see the difference it makes in this example where the modal book cover has no clear end but the cover seen in the background has a nice shadow.

image

Proposal & Constraints

Additional context

Stakeholders
@RayBB RayBB added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Mar 5, 2024
@QuantuM410
Copy link
Contributor

Hey! I would like to work on this issue. Can I get assigned?

@RayBB
Copy link
Collaborator Author

RayBB commented Mar 5, 2024

@QuantuM410 you're assigned. Take it away :)

@RayBB RayBB added Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Theme: Design Issues related to UI design, branding, etc. [managed] and removed Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Mar 5, 2024
@QuantuM410 QuantuM410 mentioned this issue Mar 5, 2024
Merged
@QuantuM410
Copy link
Contributor

@RayBB I have added the required changes in the PR. Please have a look into it :)

@mekarpeles mekarpeles added the Good First Issue Easy issue. Good for newcomers. [managed] label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QuantuM410 QuantuM410

Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added: Drop shadow to cover modal QuantuM410/openlibrary
3 participants
@RayBB @mekarpeles @QuantuM410