-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added: Drop shadow to cover modal #8870
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8870 +/- ##
=======================================
Coverage 16.02% 16.02%
=======================================
Files 89 89
Lines 4693 4693
Branches 818 818
=======================================
Hits 752 752
Misses 3434 3434
Partials 507 507 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this quick PR!
This is a good start. I'm glad you copied the styles from the existing page as that's exactly what we want.
Right now, the css also puts a border around iframes, share modal images (when you click share on the book page), and maybe others too.
Perhaps the css should only apply to images in colorbox with class="cover"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, it's working and looks good. Nice job!
Just need a staff member to merge it
Closes #8868
This PR aims to add the drop shadow to the covers modal
Technical
I just copied the previously applied css on the covers here
openlibrary/static/css/components/illustration.less
Lines 14 to 15 in 21b78ad
Testing
Screenshot
Before
After
Stakeholders
@RayBB