No Cache-Control headers on IA CDN requests

[RayBB]

Problem

These two JS load on every page: https://openlibrary.org/cdn/archive.org/donate.js and. https://openlibrary.org/cdn/archive.org/analytics.js

However, they are not cached like the rest of the JS.
This causes a lot (2 seconds) delay when on a very slow connection (only a few 100ms on a decent connection).

Their headers:

Content-Encoding: gzip
Content-Type: text/javascript
Date: Wed, 20 Mar 2024 11:48:52 GMT
Referrer-Policy: no-referrer-when-downgrade
Server: nginx/1.18.0 (Ubuntu)
Vary: Accept-Encoding
X-Ol-Stats: ""

Headers for all other requests:

Cache-Control: max-age=315360000
Content-Encoding: gzip
Content-Type: application/javascript
Date: Wed, 20 Mar 2024 11:03:17 GMT
Etag: W/"65e78c3f-69215"
Expires: Thu, 31 Dec 2037 23:55:55 GMT
Last-Modified: Tue, 05 Mar 2024 21:18:55 GMT
Referrer-Policy: no-referrer-when-downgrade
Server: nginx/1.18.0 (Ubuntu)

Evidence / Screenshot

Relevant URL(s)

Reproducing the bug

No response

Context

No response

Notes from this Issue's Lead

Proposal & constraints

Add cache control headers.

Probably should also add defer or async to their script tags so they don't block loading when they're not cached but this could be a different issue.
https://javascript.info/script-async-defer

Related files

openlibrary/openlibrary/plugins/openlibrary/code.py

Lines 425 to 430 in 45ed081

	class ia_js_cdn(delegate.page):
	path = r'/cdn/archive.org/(donate\.js|analytics\.js)'
	def GET(self, filename):
	web.header('Content-Type', 'text/javascript')
	return web.ok(fetch_ia_js(filename))

openlibrary/openlibrary/templates/site/footer.html

Lines 41 to 42 in 45ed081

	<script src="/cdn/archive.org/analytics.js" type="text/javascript"></script>
	<script src="$static_url('build/all.js')" type="text/javascript"></script>

openlibrary/openlibrary/plugins/upstream/utils.py

Lines 1468 to 1469 in 45ed081

	<div id="donato"></div>
	<script src="%s" data-platform="ol"></script>

Stakeholders

PS: I don't have bandwidth to take this right now.

[QuantuM410]

Hey! I would like to work on this issue :)

[RayBB]

@QuantuM410 go for it!

[cdrini]

Since the deploy, the number of transactions to this endpoint are ~1/4 of what they were before!

[RayBB]

@cdrini that's great thanks for the update! Is TPM thousands per minute?

Good job @QuantuM410 ! Very nice impact :)

[cdrini]

Transactions per minute!

[cdrini]

This was quite useful; would you mind creating a new issue to add the headings to partials.json ? That's another one which I think would work well with some browser-side caching! CC @jimchamp