Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache control headers to partials.json #8991

Closed
RayBB opened this issue Mar 29, 2024 · 1 comment
Closed

add cache control headers to partials.json #8991

RayBB opened this issue Mar 29, 2024 · 1 comment
Labels
Can it be closed? Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Mar 29, 2024

This was quite useful; would you mind creating a new issue to add the headings to partials.json ? That's another one which I think would work well with some browser-side caching! CC @jimchamp

Originally posted by @cdrini in #8927 (comment)

@jimchamp jimchamp added Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Apr 1, 2024
@mekarpeles mekarpeles added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Can it be closed? and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Apr 1, 2024
@cdrini
Copy link
Collaborator

cdrini commented Apr 1, 2024

After some more thinking I realized that unlike the /cdn endpoint which is hit on every pageload on openlibrary, this endpoint is different on every page; so having a browser-side cache would likely not be a huge improvement. Closing as not worth the potential benefit right now.

@cdrini cdrini closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can it be closed? Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed]
Projects
None yet
Development

No branches or pull requests

4 participants