Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize and Clean Search Inside Results #9479

Closed
merwhite11 opened this issue Jun 24, 2024 · 2 comments · Fixed by #9660
Closed

Standardize and Clean Search Inside Results #9479

merwhite11 opened this issue Jun 24, 2024 · 2 comments · Fixed by #9660
Assignees
Labels
Fellowship Opportunity Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Bug Something isn't working. [managed]

Comments

@merwhite11
Copy link
Collaborator

Problem

To complement the effort in #1001 to redirect patrons to the Search Inside results, we need to standardize the Search Inside result cards. There are currently three types of result cards in Search Inside results with UI inconsistencies:

  1. When result book is available to Borrow: Footer displays as 'Borrow & See All Results'
    • Change footer to match case 2 below -> link to all matches highlighted in text reader
  2. When result book is available to Read: Footer displays as See All Results
    • Reword 'See All Results' to more obviously signify link to all matches highlighted in text reader
  3. When result book is Preview Only: No footer
    • TBD what the footer should be

Evidence / Screenshot

Borrow result:
Screenshot 2024-06-24 at 8 53 10 AM

Read result:
Screenshot 2024-06-24 at 9 08 06 AM

Preview only result:
Screenshot 2024-06-24 at 8 58 15 AM

For consistent UI across the site, we need to update the Search Inside results to more closely match the No results Fulltext Suggestion Card implemented in #1001.

  1. Change font of snippet to serif font
  2. Add quotation marks around snippet
  3. Add page number after each snippet

Relevant URL(s)

Reproducing the bug

  1. Go to Search Inside
  2. Search 'walter' and scroll down to see all 3 UI variations of the footer.
  • Expected behavior: There should be a consistent footer with language that more clearly leads to text reader
  • Actual behavior: Inconsistent footer UI and unclear text

Context

  • Browser (Chrome, Safari, Firefox, etc):
  • OS (Windows, Mac, etc):
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Notes from this Issue's Lead

Proposal & constraints

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@merwhite11 merwhite11 added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jun 24, 2024
@merwhite11 merwhite11 self-assigned this Jun 24, 2024
@mekarpeles mekarpeles added Priority: 2 Important, as time permits. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Fellowship Opportunity Theme: Search Issues related to search UI and backend. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jun 24, 2024
@merwhite11
Copy link
Collaborator Author

@mekarpeles

Here is a proposal of a modified Search Inside result card that carries over the design elements from Search Inside Suggestion Card (#1001).

  • 3 excerpts instead of 5
  • Excerpt in serif font to distinguish from other text
  • Excerpt in blue font to indicate clickability (links to text reader)
  • Large quotes around excerpt
  • Page number
  • Reworded footer (still conditionally displayed)

Codepen: https://codepen.io/merwhite11/pen/NWVLXVa

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Jun 29, 2024
@mekarpeles
Copy link
Member

mekarpeles commented Jul 1, 2024

  1. Stick with 1 or 2 quotes for this page
  2. Padding on quote should be 10px 0 so it aligns left
  3. Author should be smaller than title (both on /search/inside and /search)
  4. Let's try the copy "Preview all X matches" and have it be within (not below) sri__extra to save height.
  5. I think the quote should be black w/ blue hover (similar to Title and Author) and the page number should be on the same line w/ —
Screenshot 2024-07-01 at 11 46 44 AM

@mekarpeles mekarpeles removed the Needs: Response Issues which require feedback from lead label Jul 1, 2024
@mekarpeles mekarpeles added this to the Sprint 2024-07 milestone Jul 5, 2024
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] and removed Priority: 2 Important, as time permits. [managed] labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fellowship Opportunity Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants