Standardize Styling for Search Inside Results #9660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merwhite11
force-pushed
the
9479/standardize-search-inside-results
branch
from
6fb07e1 to
b30affd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9660 +/- ##
==========================================
+ Coverage 16.06% 16.42% +0.36%
==========================================
Files 90 92 +2
Lines 4769 4907 +138
Branches 832 856 +24
==========================================
+ Hits 766 806 +40
- Misses 3480 3565 +85
- Partials 523 536 +13 ☔ View full report in Codecov by Sentry. |
merwhite11
force-pushed
the
9479/standardize-search-inside-results
branch
7 times, most recently
from
a68ba33 to
7f16afd
Compare
merwhite11
force-pushed
the
9479/standardize-search-inside-results
branch
from
79ce73c to
0b6b08f
Compare
for more information, see https://pre-commit.ci
mekarpeles
added
the
On testing.openlibrary.org
mekarpeles
reviewed
Aug 29, 2024
|
We may have a bug we need to work through :) |
mekarpeles
added
the
Needs: Submitter Input
github-actions
bot
removed
the
Needs: Submitter Input
|
Re: debug I am having an issue loading the test data in to web using the script provided in the Testing description above. Do I need to be on testing to reproduce the bug you're showing? Refactor: I'm realizing I should create a 'FulltextQuoatation' macro that can be shared between FulltextSuggestionSnippet and FulltextSnippet lines 16-24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9479
Technical
Merged in #9734 and combined the fulltext-suggestion-snippet.less to fulltext-snippet.less.
When this PR gets merged in, there will be a merge conflict in page-user.less where the snippet styling files are being imported.
I will need to resolve the conflict so that both FulltextSuggestionSnippet.html and FulltextSnippet.html are styled by fulltext-snippet.less from this PR.
Testing
I tested this by using a sample data json and a reference to the json in dev env: jimchamp/openlibrary@master...jimchamp:openlibrary:sandbox-fulltext-search-results#diff-fb7667454719879be914be81c253b5dd9fc0dcbdb6afaada791b5091e80e8ec2
I input the test data to the web container by running these commands:
docker compose exec -e PYTHONPATH=. web bash ./scripts/copydocs.py /books/OL24966433M ./scripts/copydocs.py /books/OL32090209M ./scripts/copydocs.py /books/OL24375865M ./scripts/copydocs.py /books/OL24204364M ./scripts/copydocs.py /books/OL7522718MThe test search term is 'a cricket in the night'
Screenshot
Stakeholders
@mekarpeles