Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for registration hide/show password toggle #9533

Closed
Tracked by #9315
rebecca-shoptaw opened this issue Jul 8, 2024 · 0 comments · Fixed by #9534
Closed
Tracked by #9315

Add icons for registration hide/show password toggle #9533

rebecca-shoptaw opened this issue Jul 8, 2024 · 0 comments · Fixed by #9534
Assignees
Labels
Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] registration Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed]

Comments

@rebecca-shoptaw
Copy link
Collaborator

rebecca-shoptaw commented Jul 8, 2024

Dependency to epic #7694. Sub-task of #9315.

Problem

One last UI touch per the registration Figma mockup, which is switching out "Hide Password"/"Show Password" for some simple eye open/closed icons.

Expected behaviour / screenshots

Password toggle mockup

Proposal & Constraints

Very simple! Just switching out the current hide/show text element for an img element, and using JavaScript to toggle the image source by adapting the existing initPasswordToggling function.

  • Planning to import icons as svg's for simplicity and customization purposes
  • There may be some troubleshooting involved to make sure the path works correctly in the move from JS to HTML
  • If the source-toggling fails, we can also put two eye icons in the HTML and use JS to toggle which is displayed
  • Will follow what seems to be the standard pattern for which icon to display -- eye closed when password is not visible, eye open when it is visible (matching current state rather than action)

Related files

create.html
password-toggle.js

Stakeholders

@cdrini


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@rebecca-shoptaw rebecca-shoptaw added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jul 8, 2024
@rebecca-shoptaw rebecca-shoptaw self-assigned this Jul 8, 2024
@rebecca-shoptaw rebecca-shoptaw added registration Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed] labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] registration Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant