-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hide/show password text with eye icons #9534
Replace hide/show password text with eye icons #9534
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9534 +/- ##
==========================================
+ Coverage 16.17% 16.29% +0.12%
==========================================
Files 90 90
Lines 4736 4761 +25
Branches 824 826 +2
==========================================
+ Hits 766 776 +10
- Misses 3453 3463 +10
- Partials 517 522 +5 ☔ View full report in Codecov by Sentry. |
5de58f3
to
7b63dea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! One small accessibility fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👁️
Closes #9533.
Feature. Switches out "Hide Password"/"Show Password" text for some simple eye open/closed icons.
Technical
password-visibility-toggle
class from thea
element to itsimg
child so that the JavaScript would activate on the correct elementa
element entirely and just put acursor: pointer
on theimg
-- held off for now in case the image nested in link is the preferred pattern for iconsTesting
/account/create
Screenshot
Stakeholders
@cdrini