Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new search box on reading log pages, author page #9557

Closed
cdrini opened this issue Jul 11, 2024 · 4 comments · Fixed by #9563
Closed

Use new search box on reading log pages, author page #9557

cdrini opened this issue Jul 11, 2024 · 4 comments · Fixed by #9563
Assignees
Labels
Affects: Experience Issues relating directly to service design & patrons experience Good First Issue Easy issue. Good for newcomers. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Jul 11, 2024

Problem

The reading log pages, e.g. https://openlibrary.org/people/ScarTissue/books/want-to-read , and the author page, e.g. https://openlibrary.org/authors/OL33146A/Franz_Kafka , feature search boxes which should use the new updated style introduced in #9146

image

image

Proposal & Constraints

What is the proposed solution / implementation?

Is there a precedent of this approach succeeding elsewhere?

Which suggestions or requirements should be considered for how feature needs to appear or be implemented?

Leads

Related files

Reading log pages:

<form method="GET" class="olform pagesearchbox">
<input type="text" minlength="3" placeholder="$_('Search your reading log')" name="q" value="$(query_param('q', ''))"/>
<input type="submit"/>
</form>

Author pages:

<input type="text" placeholder="Search $title Books" name="q" value="$(query_param('q', ''))"/>

Stakeholders

@0simoo


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@cdrini cdrini added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jul 11, 2024
@Souvik-Cyclic
Copy link
Contributor

Souvik-Cyclic commented Jul 11, 2024

@cdrini I want to work on this, assign this to me.

@mekarpeles mekarpeles added Theme: Search Issues related to search UI and backend. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Affects: Experience Issues relating directly to service design & patrons experience and removed Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Jul 11, 2024
@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Jul 12, 2024
@cdrini
Copy link
Collaborator Author

cdrini commented Jul 16, 2024

Apologies for the confusion folks, I didn't see the comments in time. I'm leaving this one with @dwrik since they opened a PR and are actively working on it, although for future reference @dwrik, if there are comments from other contributors on an issue please do wait for a maintainer to respond before beginning 👍

@dwrik
Copy link
Contributor

dwrik commented Jul 16, 2024

@cdrini

Apologies from my end as well. The issue wasn't assigned and there was no confirmation on whether someone had started working on it so I assumed it wasn't being worked on by anyone. Nonetheless, from next time onwards, will wait for a maintainer to respond before working on it. Thanks.

@educonnec

This comment was marked as off-topic.

@cdrini cdrini removed the Needs: Response Issues which require feedback from lead label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Experience Issues relating directly to service design & patrons experience Good First Issue Easy issue. Good for newcomers. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
5 participants