Use new search box on reading log pages and author page

[dwrik]

Closes #9557

This PR fixes issue #9557 by implementing new search box in author and reading log pages

Technical

Replaced input tags with render_template() call

Testing

Go to My Books -> Reading log (left side menu) pages or go directly to any author's page

Screenshot

Old search box:

New search box:

Author page

Reading log pages

Stakeholders

@cdrini

[cdrini]

Make the wording relative to the page it's on; e.g. "Search reading log" like it was before 👍

[dwrik]

@cdrini Sure, will do. Thanks.

[dwrik]

@cdrini @jimchamp

Updated to reflect current page in placeholder text

Reading Log

Author Page

[dwrik]

Hi @cdrini @jimchamp,

Just a friendly follow-up to see if there's any additional feedback or steps needed on this PR. If everything looks good, we can go ahead and merge it.

Thanks for your time!

Best,
dwrik

[jimchamp]

Thanks @dwrik!
It looks like all of the placeholder strings are hard-coded English. The suggested changes, when made, will replace the English string with a translation in the patron's local language (if such a translation exists).

More information on how Open Library handles internationalization can be found here

[dwrik]

@jimchamp

Apologies, I missed the i18n translations. I've rebased the branch to include new changes and fixed the i18n issues by using the suggestions provided and fixed them where necessary (title was hardcoded, fixed that). Tested it locally and it works as expected. Let me know if any further changes required.

Thanks.

[dwrik]

@jimchamp,

I have addressed the requested changes. Just wanted to check if there are any additional steps needed from my side.

Thanks!

[jimchamp]

Lgtm. Thanks, @dwrik!

[LeadSongDog]

Not sure if this effort caused it, but:

[cdrini]

^ Unrelated; will be fixed by #9719 .