Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve searchbar keyboard input #10104

Merged
merged 4 commits into from
Dec 4, 2024
Merged

improve searchbar keyboard input #10104

merged 4 commits into from
Dec 4, 2024

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Dec 2, 2024 •
edited
Loading

  • clear search results on tab
  • stop rerending on focus of input
  • fixed tabbing when on search results + working test

Closes #10103

Technical

Testing

Added some tests but see video for demo

Screenshot

searchbar.mp4

Stakeholders

@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Dec 2, 2024
@mekarpeles mekarpeles added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Dec 2, 2024
@mekarpeles mekarpeles self-assigned this Dec 2, 2024
cdrini
cdrini approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Great work and attention to detail 😊 And I appreciate the unit tests!

@cdrini cdrini merged commit 19c7150 into master Dec 4, 2024
5 checks passed
@cdrini cdrini deleted the fix-search-tab branch December 4, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrini cdrini cdrini approved these changes

Assignees

@mekarpeles mekarpeles

Labels
Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clear searchbar when we tab off of the search bar input
3 participants
@RayBB @cdrini @mekarpeles