changed the innerHTML with textContent for security reasons #10105
Conversation
There was a problem hiding this comment.
Thanks @ronibhakta1! I've confirmed that everything is working.
Happy to merge this once the commented code on lines 134-137 are removed.
| // memberRole.classList = 'description__role'; | ||
| // memberRole.innerHTML = `${role}`; | ||
| // memberRole.textContent = `${role}`; | ||
| // memberDepartment.classList = 'description__department'; | ||
| // memberDepartment.innerHTML = `${member.departments}`; | ||
| // memberDepartment.textContent = `${member.departments}`; |
There was a problem hiding this comment.
Can you remove these comments altogether?
There was a problem hiding this comment.
Yeah sure i will update you with the changes
There was a problem hiding this comment.
Can you remove these comments altogether?
hey @jimchamp i made the required changes you can check that out !
commented lines removal
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10105 +/- ##
=======================================
Coverage 17.12% 17.13%
=======================================
Files 89 89
Lines 4752 4792 +40
Branches 831 845 +14
=======================================
+ Hits 814 821 +7
- Misses 3428 3450 +22
- Partials 510 521 +11 ☔ View full report in Codecov by Sentry. |
Closes #10097
Hey @jimchamp i have made the changes in innerHTML with textContent for security reasons as you mentioned.
Technical
changes in the
team.jsfile to increase the security.Testing
no build errors and no other syntactical errors. all changes are preferable as per the documentations
Screenshot
Stakeholders