Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail gracefully on account creation timeout #10121

Merged

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented Dec 5, 2024

Addresses #10035

Adds new request_timeout authentication error message. Updates xauthn to throw an error iff the authentication service returns a 504 during a create operation.

Technical

Testing

Screenshot

Screenshot 2024-12-05 104958
The new error message.

Stakeholders

@jimchamp jimchamp marked this pull request as draft December 5, 2024 19:14
@jimchamp jimchamp force-pushed the graceful-account-creation-failures branch from 8a6e21c to 6194ace Compare December 5, 2024 19:21
@jimchamp jimchamp marked this pull request as ready for review December 5, 2024 19:28
@mekarpeles mekarpeles self-assigned this Dec 16, 2024
@mekarpeles mekarpeles added Priority: 1 Do this week, receiving emails, time sensitive, . [managed] On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing labels Dec 16, 2024
@mekarpeles
Copy link
Member

LGTM, throwing on testing.

@mekarpeles mekarpeles merged commit d0a9b51 into internetarchive:master Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Testing On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants