Adding 'CreateSpace Independent Publishing Platform' to the list of independent publishers that should not be imported. #10158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dependent publishers not to be imported.
DebbieSan
changed the title
scottbarnes
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Looks good to me. Thanks, @DebbieSan!
Thanks also for fixing that latent design flaw I had in there, such that only one side of the comparison was necessarily casefolded.
DebbieSan
changed the title
DebbieSan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10128
Adds 'CreateSpace Independent Publishing Platform' to the list of independent publishers that should not be imported.
Technical
Besides rectifying the issue, I also Implemented tests and added casefold to the independent publisher list to prevent case errors in future updates.
Testing
Tests have been updated to include the new case.
Stakeholders
@seabelis
@scottbarnes
@mekarpeles