Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed arrow alignment #10169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Craig-Rosario
Copy link
Contributor

@Craig-Rosario Craig-Rosario commented Dec 19, 2024

Closes #10134

Align/Fix the navigation arrows, positioning them on the sides of the covers for better usability.

Technical

Testing

  1. Go to the add-cover section of a book (eg. https://openlibrary.org/works/OL69166W/Italian_journeys/add-cover)

Screenshot

Before:
Screenshot 2024-12-19 121132

After:
Screenshot 2024-12-19 121909

Stakeholders

@mekarpeles

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.44%. Comparing base (347bff9) to head (a936ff1).
Report is 168 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10169      +/-   ##
==========================================
+ Coverage   17.12%   17.44%   +0.31%     
==========================================
  Files          89       89              
  Lines        4752     4792      +40     
  Branches      831      848      +17     
==========================================
+ Hits          814      836      +22     
- Misses       3428     3436       +8     
- Partials      510      520      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return cover selector navigation to right and left placement
3 participants