Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more inappropriate content in kids carousel #2826

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

tabshaikh
Copy link
Collaborator

Closes #2820

Technical

removed preset:children and added subject(Juvenile Fiction) in query

Stakeholders

@mekarpeles

@tabshaikh tabshaikh requested a review from mekarpeles January 7, 2020 14:17
@tfmorris
Copy link
Contributor

tfmorris commented Jan 7, 2020

#3 in the Juvenile Fiction carousel is Shakespeare's Macbeth which doesn't really seem appropriate, so I think we need to be a little more discriminating.

@seabelis
Copy link
Collaborator

seabelis commented Jan 8, 2020

#3 in the Juvenile Fiction carousel is Shakespeare's Macbeth which doesn't really seem appropriate, so I think we need to be a little more discriminating.

I think that might be from adaptations that are/were associated with the work. I see this frequently, but unless the associated editions are moved to another work, I think the subject tags eventually repopulate if removed. I've gone through Hamlet, Romeo and Juliet, and Tempest with a fairly fine-toothed comb, but it's a bit like herding cats and not possible to maintain at scale. Additionally, texts used in schools frequently have the Juvenile Fiction subject tag as well even if they are not particularly childish.

I think there is no perfect solution without using managed taxonomy. It's an improvement, so let's not make perfect the enemy of good. JUVENILE LITERATURE would broaden the results to include non-fiction which might be nice. Or if the objective is to populate the carousel with picture books, use that as the subject. https://openlibrary.org/subjects/picture_books

@cdrini cdrini added the On Dev label Jan 8, 2020
@cdrini
Copy link
Collaborator

cdrini commented Jan 8, 2020

Note that this maps to an archive.org query; not an OL query. So it's not related to https://openlibrary.org/subjects/juvenile_fiction .

@mekarpeles
Copy link
Member

LGTM, we can address remaining issues archive.org side (such as those mentioned). Thank you @tabshaikh!

@mekarpeles mekarpeles merged commit b5bedeb into internetarchive:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kids carousel query resulting in inappropriate content
5 participants