Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused imports from code.py & conftest.py #3447

Merged
merged 3 commits into from
Jan 9, 2021
Merged

Remove unused imports from code.py & conftest.py #3447

merged 3 commits into from
Jan 9, 2021

Conversation

imskr
Copy link
Contributor

@imskr imskr commented May 7, 2020 •
edited
Loading

Removes the unused import from openlibrary/code.py & openlibrary/conftest.py

  • openlibrary/mocks
  • openlibrary/accounts and openlibrary/admin
  • openlibrary/code.py and openlibrary/conftest.py
  • openlibrary/coverstore
  • openlibrary/data
  • openlibrary/records
  • openlibrary/solr
  • openlibrary/utils
  • openlibrary/views

Save for the end:

  • openlibrary/core
  • openlibrary/catalog (perhaps multiple PRs)
  • openlibrary/plugins (perhaps multiple PRs)

Stakeholders

@cclauss @mekarpeles

@imskr
Copy link
Contributor Author

imskr commented May 7, 2020

Failed.

cclauss
cclauss suggested changes May 7, 2020
View reviewed changes
openlibrary/conftest.py Show resolved Hide resolved
Shubham Kumar and others added 2 commits May 11, 2020 09:55
@imskr
Copy link
Contributor Author

imskr commented May 11, 2020

@cclauss It's done.

Previous Build:
===== 36 failed, 588 passed, 23 skipped, 10 xfailed, 40 warnings in 5.68s ======
Makefile:75: recipe for target 'test' failed
make: *** [test] Error 1
The command "make test" exited with 2.

This Build:
===== 36 failed, 588 passed, 23 skipped, 10 xfailed, 42 warnings in 5.96s ======
Makefile:75: recipe for target 'test' failed
make: *** [test] Error 1
The command "make test" exited with 2.

cclauss
cclauss approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only failing test is run in allow_failures mode.

@imskr imskr mentioned this pull request Jun 2, 2020
Closed
@jdlrobson jdlrobson merged commit 5c43c3c into internetarchive:master Jan 9, 2021
Sabreen-Parveen pushed a commit to Sabreen-Parveen/openlibrary that referenced this pull request Feb 5, 2021
@imskr @Sabreen-Parveen
Remove unused imports from code.py & conftest.py (internetarchive#3447)
005834f 
* remove unused imports from code.py & conftest.py

* ignore F401 flake8

* ignore F401 flake8

Co-authored-by: Shubham Kumar <skr@pop-os.localdomain>
Sabreen-Parveen pushed a commit to Sabreen-Parveen/openlibrary that referenced this pull request Feb 5, 2021
@imskr @Sabreen-Parveen
Remove unused imports from code.py & conftest.py (internetarchive#3447)
5c588f5 
* remove unused imports from code.py & conftest.py

* ignore F401 flake8

* ignore F401 flake8

Co-authored-by: Shubham Kumar <skr@pop-os.localdomain>
Sabreen-Parveen pushed a commit to Sabreen-Parveen/openlibrary that referenced this pull request Feb 5, 2021
@imskr @Sabreen-Parveen
Remove unused imports from code.py & conftest.py (internetarchive#3447)
5ed1734 
* remove unused imports from code.py & conftest.py

* ignore F401 flake8

* ignore F401 flake8

Co-authored-by: Shubham Kumar <skr@pop-os.localdomain>
Sabreen-Parveen pushed a commit to Sabreen-Parveen/openlibrary that referenced this pull request Feb 5, 2021
@imskr @Sabreen-Parveen
Remove unused imports from code.py & conftest.py (internetarchive#3447)
22fb96d 
* remove unused imports from code.py & conftest.py

* ignore F401 flake8

* ignore F401 flake8

Co-authored-by: Shubham Kumar <skr@pop-os.localdomain>
Sabreen-Parveen pushed a commit to Sabreen-Parveen/openlibrary that referenced this pull request Feb 5, 2021
@imskr @Sabreen-Parveen
Remove unused imports from code.py & conftest.py (internetarchive#3447)
7424f4b 
* remove unused imports from code.py & conftest.py

* ignore F401 flake8

* ignore F401 flake8

Co-authored-by: Shubham Kumar <skr@pop-os.localdomain>
Sabreen-Parveen pushed a commit to Sabreen-Parveen/openlibrary that referenced this pull request Feb 15, 2021
@imskr @Sabreen-Parveen
Remove unused imports from code.py & conftest.py (internetarchive#3447)
2ffc172 
* remove unused imports from code.py & conftest.py

* ignore F401 flake8

* ignore F401 flake8

Co-authored-by: Shubham Kumar <skr@pop-os.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

@mekarpeles mekarpeles

@cdrini cdrini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@imskr @cclauss @jdlrobson @mekarpeles @cdrini