refactor update_work and test_update_work to use requests #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
Aug 14, 2020
|
Not (yet) mandatory... https://travis-ci.org/github/internetarchive/openlibrary/jobs/717652021#L433-L447 |
cclauss
reviewed
Aug 14, 2020
|
I also see this in the changed files - @cclauss - not very sure about this, but it shouldn't be present, right? maybe i did
|
|
@cclauss I just confirmed - this does change the submodule settings for |
aasifkhan7
force-pushed
the
modify-update_work-to-requests
branch
from
13570f3 to
1db9d23
Compare
|
Done @cclauss |
… into modify-update_work-to-requests
|
@cdrini @mekarpeles @hornc I have approved this PR. It would be good to get your reviews. |
cdrini
approved these changes
Sep 8, 2020
aasifkhan7
added a commit
to aasifkhan7/openlibrary
that referenced
this pull request
Sep 8, 2020
…ternetarchive#3696)" This reverts commit eccf887.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2852
related to #3694
@cclauss Refactor only
update_work.pyandtest_update_work.py