Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: Set reasonable defaults for hostname and pyenv_version #4056

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Docker: Set reasonable defaults for hostname and pyenv_version #4056

merged 2 commits into from
Nov 9, 2020

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 9, 2020 •
edited
Loading

Modifies docker-compose.production.yml and docker-compose.staging.yml to ensure that:

  1. hostname is properly set on both bash and zsh
  2. $PYEVN_VERSION has a reasonable default if not set on the command line.

Technical

Testing

Screenshot

Stakeholders

@cclauss cclauss requested a review from cdrini November 9, 2020 17:34
cdrini
cdrini requested changes Nov 9, 2020
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix some issues with PYENV_VERSION syntax

docker-compose.production.yml Outdated Show resolved Hide resolved
docker-compose.staging.yml Outdated Show resolved Hide resolved
cdrini
cdrini approved these changes Nov 9, 2020
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm; not testing

@cdrini cdrini merged commit f6e2841 into internetarchive:master Nov 9, 2020
@cclauss cclauss deleted the fix-Docker-hostname-for-bash-and-zsh branch November 9, 2020 19:21
@cdrini cdrini self-assigned this Nov 17, 2020
This was referenced Sep 26, 2022
Open
Open
This was referenced Oct 7, 2022
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrini cdrini cdrini approved these changes

Assignees

@cdrini cdrini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @cdrini