Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infobase running on ol-home #4114

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Infobase running on ol-home #4114

merged 3 commits into from
Nov 17, 2020

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 17, 2020

Like #4112, #4113 but for infobase running on ol-home

$INFOBASE_OPTS is probably wrong!!

Technical

Testing

Screenshot

Stakeholders

@cclauss cclauss requested review from mekarpeles and cdrini November 17, 2020 17:42
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those options in the supervisortctl can't be applied via the CLI; but thankfully we don't really need any of them thanks to docker 😎 The script will automatically be run with the correct user/directory, and the logs will be managed by docker as well.

docker-compose.production.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker/ol-infobase-start.sh Outdated Show resolved Hide resolved
@cdrini cdrini self-assigned this Nov 17, 2020
Co-authored-by: Drini Cami <cdrini@gmail.com>
build:
context: .
dockerfile: docker/Dockerfile.oldev
command: docker/ol-infobase-start.sh
ports:
- 7000:7000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only want this for production; on local we want it on 7000

Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! @cclauss confirmed the local dev env was still working correctly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants