Make Metric System as Default for Physical Values of the Book. #4134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cdrini please review this PR |
RayBB
added
the
Needs: Review
|
Apologies for the silence here! We brought this up long ago during a community call and got caught in a quagmire about trying to make this change depending on locale. But this PR looks good as is! Assigning to @RayBB who graciously agreed to give it a test and move it forward! |
cdrini
reviewed
Oct 26, 2023
|
Steps to test (from Drini):
|
|
@cdrini I just completed the tests and all is working! SpoilerMake.Metric.System.as.Default.for.Physical.Values.of.the.Book.by.nk4456542.Pull.Request.4134.internetarchive_openlibrary.-.27.January.2024.mp4 |
RayBB
approved these changes
Jan 27, 2024
cdrini
removed
the
Needs: Review
|
Thanks @nk4456542 and @RayBB for testing and reviewing! |
Achorn
pushed a commit
to Achorn/openlibrary
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2242
Make the Metric System as Default for Physical Values of the Book while editing. Most comments in the issue favored the metric system so went with the metric.
Technical
Not that much technical, just changed the default to
centimetersfrominchesand tokilosfromgrams.Testing
docker-compose exec web make testreturned no errors.Screenshot
Stakeholders
@seabelis @cdrini