Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardizes call to action as "borrow" #4374

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

mekarpeles
Copy link
Member

@mekarpeles mekarpeles commented Jan 7, 2021

Closes #4360 which standardizes all borrow calls to action as "Borrow" rather than e.g. 1h since all borrows now originate as 1 hour.

Technical

Within the PR, the code block logic for available_to_browse and available_to_borrow not merged in case we do want different copy in the future.

Screenshot

openlibrary org_books_OL362125M_Rainbow_Six
dev openlibrary org_books_OL362125M_Rainbow_Six
dev openlibrary org_ (2)
dev openlibrary org_search_q=stellaluna mode=everything

Stakeholders

@cdrini @bfalling @brewsterkahle

Closes #4360 which standardizes all borrow calls to action as "Borrow" rather than e.g. 1h since all borrows now originate as 1 hour.
@mekarpeles mekarpeles added the On Staging On staging.openlibrary.org label Jan 7, 2021
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cclauss cclauss merged commit 2daebf4 into master Jan 7, 2021
@cclauss cclauss deleted the 4360/refactor/copy-for-1h-borrow branch January 7, 2021 11:02
Sabreen-Parveen pushed a commit to Sabreen-Parveen/openlibrary that referenced this pull request Feb 5, 2021
Closes internetarchive#4360 which standardizes all borrow calls to action as "Borrow" rather than e.g. 1h since all borrows now originate as 1 hour.
Sabreen-Parveen pushed a commit to Sabreen-Parveen/openlibrary that referenced this pull request Feb 5, 2021
Closes internetarchive#4360 which standardizes all borrow calls to action as "Borrow" rather than e.g. 1h since all borrows now originate as 1 hour.
Sabreen-Parveen pushed a commit to Sabreen-Parveen/openlibrary that referenced this pull request Feb 5, 2021
Closes internetarchive#4360 which standardizes all borrow calls to action as "Borrow" rather than e.g. 1h since all borrows now originate as 1 hour.
Sabreen-Parveen pushed a commit to Sabreen-Parveen/openlibrary that referenced this pull request Feb 5, 2021
Closes internetarchive#4360 which standardizes all borrow calls to action as "Borrow" rather than e.g. 1h since all borrows now originate as 1 hour.
Sabreen-Parveen pushed a commit to Sabreen-Parveen/openlibrary that referenced this pull request Feb 5, 2021
Closes internetarchive#4360 which standardizes all borrow calls to action as "Borrow" rather than e.g. 1h since all borrows now originate as 1 hour.
Sabreen-Parveen pushed a commit to Sabreen-Parveen/openlibrary that referenced this pull request Feb 15, 2021
Closes internetarchive#4360 which standardizes all borrow calls to action as "Borrow" rather than e.g. 1h since all borrows now originate as 1 hour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging On staging.openlibrary.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy for "Borrow" button
3 participants