-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standardizes call to action as "borrow" #4374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #4360 which standardizes all borrow calls to action as "Borrow" rather than e.g. 1h since all borrows now originate as 1 hour.
cclauss
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Jan 7, 2021
Closed
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
Closes internetarchive#4360 which standardizes all borrow calls to action as "Borrow" rather than e.g. 1h since all borrows now originate as 1 hour.
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
Closes internetarchive#4360 which standardizes all borrow calls to action as "Borrow" rather than e.g. 1h since all borrows now originate as 1 hour.
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
Closes internetarchive#4360 which standardizes all borrow calls to action as "Borrow" rather than e.g. 1h since all borrows now originate as 1 hour.
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
Closes internetarchive#4360 which standardizes all borrow calls to action as "Borrow" rather than e.g. 1h since all borrows now originate as 1 hour.
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
Closes internetarchive#4360 which standardizes all borrow calls to action as "Borrow" rather than e.g. 1h since all borrows now originate as 1 hour.
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 15, 2021
Closes internetarchive#4360 which standardizes all borrow calls to action as "Borrow" rather than e.g. 1h since all borrows now originate as 1 hour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4360 which standardizes all borrow calls to action as "Borrow" rather than e.g. 1h since all borrows now originate as 1 hour.
Technical
Within the PR, the code block logic for available_to_browse and available_to_borrow not merged in case we do want different copy in the future.
Screenshot
Stakeholders
@cdrini @bfalling @brewsterkahle