Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed edition-header h3 spacing #4393

Merged
merged 5 commits into from
Jan 10, 2021
Merged

Fixed edition-header h3 spacing #4393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
221012f
Fixed edition-header h3 spacing
SaravgiYash Jan 9, 2021
a40f128
minor fix
SaravgiYash Jan 9, 2021
054801d
final fix :)
SaravgiYash Jan 9, 2021
f0541b8
minor fix
SaravgiYash Jan 9, 2021
c3f0909
minor fix
SaravgiYash Jan 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions openlibrary/templates/type/edition/view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,13 +339,13 @@ <h3>
<hr>
$if edition.first_sentence:
<div>
<h3 class="collapse">$_("First Sentence")</h3>
SaravgiYash marked this conversation as resolved.
Show resolved Hide resolved
<h3 class="edition-header">$_("First Sentence")</h3>
<p>"$(edition.first_sentence)"</p>
</div>

$if edition.description:
<div class="section">
<h3>$_("Edition Description")</h3>
<h3 class="edition-header">$_("Edition Description")</h3>
<div class="edition-description">
<div class="addReadMore showlesscontent">
$:sanitize(format(edition.description))
Expand All @@ -360,7 +360,7 @@ <h3>$_("Edition Description")</h3>

$if edition.notes or edition.series or edition.volume or edition.genres or edition.other_titles or edition.copyright_date or edition.translation_of or edition.translated_from:
<div class="section">
<h3>$_("Edition Notes")
<h3 class="edition-header">$_("Edition Notes")
</h3>
$if edition.notes:
$:format(edition.notes)
Expand Down Expand Up @@ -403,7 +403,7 @@ <h3 class="header">
$ contributors = edition.get('contributors', [])
$if contributors:
<div class="section">
<h3 class="collapse">$_("Contributors")</h3>
<h3 class="edition-header">$_("Contributors")</h3>
<dl class="meta">
$for c in contributors:
$:display_value(c.role, c.name)
Expand Down
10 changes: 5 additions & 5 deletions static/css/components/work.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@
// Center (editionAbout)
div.editionAbout {
SaravgiYash marked this conversation as resolved.
Show resolved Hide resolved
margin-bottom: 20px;
h3 {
font-size: 14px;
margin: 0 0 0em;
}

p {
margin: 1em 0;
font-size: 13px;
Expand Down Expand Up @@ -96,6 +91,11 @@ vertical-align: middle;
font-size: .8em;
}

h3.edition-header {
font-size: 14px;
margin: 0 0 0em;
}

h2.edition-byline {
margin: 7px 2px 20px;
}
Expand Down