Fix AttributeError: 'author_names'

[SaravgiYash]

Closes https://internetarchive.slack.com/archives/C0ETZV72L/p1610879197058400
NOTE: Instead of (edition or work).author_names we can write page.author_names

Refer: https://internetarchive.slack.com/archives/C0ETZV72L/p1610978647060400?thread_ts=1610879197.058400&cid=C0ETZV72L

Testing

https://openlibrary.org/works/OL15690362W/Walt_Disney_fun-to-read_library_(duplicate)
https://openlibrary.org/works/OL17355493W/The_Generic_names_of_moths_of_the_world._n_Vol._5_p_Pyraloidea_c_edited_by_I.W.B._Nye_vol._5_by_D.S.

Screenshot

Stakeholders

[cclauss]

For the case where this code is currently failing, page.key.startswith('/????')?

I find openlibrary/templates/type/edition/view.html to be nasty code. Every time someone touches it, those changes break something else. My sense is this file gets heavy user traffic yet its logic is muddled. I view the file as a candidate for a rewrite. We should have separate logic flows for page.key.startswith('/books'), page.key.startswith('/works'), etc. to remove the current patches on patches. What are all the page.keys that this code needs to support? Do all page types have a page.author_names attribute?

[SaravgiYash]

I find openlibrary/templates/type/edition/view.html to be nasty code. Every time someone touches it, those changes break something else. My sense is this file gets heavy user traffic yet its logic is muddled. I view the file as a candidate for a rewrite. We should have separate logic flows for page.key.startswith('/books'), page.key.startswith('/works'), etc. to remove the current patches on patches. What are all the page.keys that this code needs to support? Do all page types have a page.author_names attribute?

@cclauss we should also focus on documentation (for instance, this particular file has 0 comments).

[jdlrobson]

Can confirm this patch fixes the error. Totally agree that openlibrary/templates/type/edition/view.html is long overdue a rewrite.