Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidating vendors back to core group #4454

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Conversation

mekarpeles
Copy link
Member

@mekarpeles mekarpeles commented Jan 21, 2021

consolidating vendors modified last by #3069

BK has asked to avoid a large list of vendors overwhelming the page. Suggestion is to consolidate as is mentioned in this PR.

Option to add a e.g. "other vendors" dropdown like goodreads
image
which shows more options.

See #4466

We could do something similar for libraries as well (similar to goodreads) Turn Worldcat + LibraryLink into a dropdown button + also (on click) load ~3 nearby libraries from librarylink API into that list

Stakeholders

@bfalling

Copy link
Collaborator

@bfalling bfalling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mekarpeles mekarpeles added the Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed] label Jan 23, 2021
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdrini cdrini merged commit 492f402 into master Jan 26, 2021
@cdrini cdrini deleted the consolidating-vendors branch January 26, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants