Support special access btn for patrons w/ approved print-disabilities #4491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekarpeles
commented
Jan 26, 2021
cclauss
reviewed
Jan 26, 2021
cclauss
reviewed
Feb 2, 2021
mekarpeles
changed the title
cclauss
reviewed
Feb 6, 2021
|
Note considerations: May require care re: caching homepage carousel html! |
mekarpeles
force-pushed
the
feature/print-disabled-accounts
branch
from
a99190c to
a902124
Compare
mekarpeles
commented
Feb 11, 2021
mekarpeles
commented
Feb 11, 2021
mekarpeles
added
the
Priority: 1
cdrini
requested changes
Feb 11, 2021
Co-authored-by: Drini Cami <cdrini@gmail.com>
|
Also notes:
|
|
All PR feedback should be addressed and tested during a call on staging. Going to merge. I think we should do a round of testing on Tuesday before any additional deploys (as we have a handful of changes inbound) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4490
Request from directors, have Open Library provide patrons with qualified print-disabilities an accurate depiction of which books are available to them. Dates back to our 2018 roadmap:
https://docs.google.com/document/d/1wpa4f-r8jBimam-36CAZGQ_QjApegm10XfH85eG7KAE/edit#
Technical
Uses the xauthn API which has been updates to return printdisability qualifications
Testing
Tested on dev.openlibrary.org (not yet on staging)
Considerations
May require care re: caching homepage carousel html!
Screenshot
Stakeholders