Update item count on deletion #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
requested changes
Feb 2, 2021
cdrini
added
the
Needs: Submitter Input
cdrini
reviewed
Feb 3, 2021
| @@ -112,7 +112,7 @@ <h1>$list.name</h1> | |||
| remove_seed(list_key, seed, function() { | |||
| \$(seed_id).remove(); | |||
| // update seed count | |||
| \$("#seed-count").html(render_seed_count(get_seed_count())); | |||
| \$("#list-items-count").html(render_seed_count(get_seed_count())); | |||
There was a problem hiding this comment.
Sigh it did this :P
Let's use your initial load function; that will work better 👍
cdrini
approved these changes
Feb 4, 2021
Sabreen-Parveen
added a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4517
Updates item count whenever an item is deleted by a patron.
Technical
Testing
Screenshot
Stakeholders