Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color contrast issue for buttons #4538

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

SaravgiYash
Copy link
Contributor

Closes #4523
Contrast Ratio
Old : 2.84:1
New : 5.74:1

Screenshot

image

Stakeholders

@bpmcneilly

@SaravgiYash
Copy link
Contributor Author

SaravgiYash commented Feb 4, 2021

@bpmcneilly we also need to fix the Join Waitlist buttons:
The contrast ratio for the Waitlist button is: 2.01:1
Solution: make the foreground color: black

image

@cclauss cclauss added Affects: UI Issues with the web site's user interface. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] labels Feb 4, 2021
@mekarpeles mekarpeles merged commit ae29008 into internetarchive:master Feb 6, 2021
@SaravgiYash
Copy link
Contributor Author

@mek there is one more color contrast issue related to buttons

@bpmcneilly we also need to fix the Join Waitlist buttons:
The contrast ratio for the Waitlist button is: 2.01:1
Solution: make the foreground color: black

image

matrix101A added a commit to matrix101A/openlibrary that referenced this pull request Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: UI Issues with the web site's user interface. [managed] Theme: Design Issues related to UI design, branding, etc. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home Page Color Contrast
3 participants