Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to deploy.sh #4544

Merged
merged 1 commit into from
Feb 7, 2021
Merged

Updates to deploy.sh #4544

merged 1 commit into from
Feb 7, 2021

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 5, 2021

Closes issues discovered on https://github.com/internetarchive/openlibrary/releases/tag/deploy-2021-02-04

Technical

Testing

Screenshot

Stakeholders

@cclauss cclauss added the Affects: Operations Affects the IA DevOps folks label Feb 5, 2021
@cclauss cclauss added this to the Active Sprint milestone Feb 5, 2021
@cclauss cclauss requested a review from cdrini February 5, 2021 11:44
mekarpeles
mekarpeles approved these changes Feb 7, 2021
View reviewed changes
Copy link
Member

@mekarpeles mekarpeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this is the same code we ran during last deploy; lgtm, uses correct bash quoting (tested on call)

@mekarpeles mekarpeles self-assigned this Feb 7, 2021
@mekarpeles mekarpeles merged commit fe7cda4 into master Feb 7, 2021
@mekarpeles mekarpeles deleted the Updates-to-deploy.sh branch February 7, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mekarpeles mekarpeles mekarpeles approved these changes

@cdrini cdrini Awaiting requested review from cdrini

Assignees

@mekarpeles mekarpeles

Labels
Affects: Operations Affects the IA DevOps folks
Projects
None yet
Milestone
Sprint 2021-02
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @mekarpeles