Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web-haproxy and web-nginx to docker-compose.production.yml #4566

Closed
wants to merge 6 commits into from
Closed

Add web-haproxy and web-nginx to docker-compose.production.yml #4566

wants to merge 6 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 10, 2021 •
edited
Loading

Subtask of #4252

Add www-haproxy and www-nginx to docker-compose.production.yml so we can replace the server ol-www1 with a Docker-based ol-www0.

Technical

Testing

Rejected by Jenkins:

The Compose file './docker-compose.yml' is invalid because:
services.web.expose is invalid: should be of the format 'PORT[/PROTOCOL]'

http://server.openjournal.foundation:8081/blue/organizations/jenkins/ol-staging%20deploy/detail/ol-staging%20deploy/171/pipeline/60

Screenshot

Stakeholders

@cclauss cclauss added Module: Docker Issues related to the configuration or use of Docker. [managed] Affects: Configuration Related to the configuration of the dev/staging/prod environments, CI, docker, etc. [managed] labels Feb 10, 2021
@cclauss cclauss added this to the Active Sprint milestone Feb 10, 2021
@cclauss cclauss requested a review from cdrini February 10, 2021 14:16
@cclauss cclauss mentioned this pull request Feb 10, 2021
Closed
28 tasks
@cclauss cclauss requested a review from mekarpeles February 11, 2021 21:01
@cclauss cclauss changed the title DRAFT: Add www-haproxy and www-nginx to docker-compose.production.yml DRAFT: Add web-haproxy and web-nginx to docker-compose.production.yml Feb 11, 2021
@mekarpeles mekarpeles self-assigned this Feb 12, 2021
@cclauss cclauss mentioned this pull request Feb 18, 2021
Closed
@cclauss cclauss changed the title DRAFT: Add web-haproxy and web-nginx to docker-compose.production.yml Add web-haproxy and web-nginx to docker-compose.production.yml Feb 21, 2021
@cclauss cclauss marked this pull request as ready for review February 21, 2021 22:19
@cclauss cclauss marked this pull request as draft February 22, 2021 15:22
@cdrini cdrini modified the milestones: Sprint 2021-02, Active Sprint Mar 1, 2021
@cclauss
Copy link
Contributor Author

cclauss commented Apr 1, 2021

Do we still need this or have you moved beyond?

@cclauss cclauss closed this Apr 7, 2021
@cclauss cclauss deleted the Add-www0-to-docker-compose.production.yml branch April 7, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrini cdrini Awaiting requested review from cdrini

@mekarpeles mekarpeles Awaiting requested review from mekarpeles

Assignees

@mekarpeles mekarpeles

Labels
Affects: Configuration Related to the configuration of the dev/staging/prod environments, CI, docker, etc. [managed] Module: Docker Issues related to the configuration or use of Docker. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @mekarpeles @cdrini