Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/affiliate disclaimer #4656

Merged
merged 6 commits into from
Feb 22, 2021
Merged

Hotfix/affiliate disclaimer #4656

merged 6 commits into from
Feb 22, 2021

Conversation

mekarpeles
Copy link
Member

@mekarpeles mekarpeles commented Feb 22, 2021

Closes request for visible affiliate disclosure

Test here:
https://dev.openlibrary.org/books/OL15626440M/Problem-based_learning

  • bwb links should still resolve
  • disclosure message should appear in vendors box

dev openlibrary org_books_OL1409749M_A_Night_in_the_Lonesome_October

Screenshot

Stakeholders

@bfalling

Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment for better semantic HTML

openlibrary/macros/AffiliateLinks.html Show resolved Hide resolved
Copy link
Collaborator

@bfalling bfalling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Drini Cami <cdrini@gmail.com>
@mekarpeles mekarpeles merged commit e561b8d into master Feb 22, 2021
@mekarpeles mekarpeles deleted the hotfix/affiliate-disclaimer branch February 22, 2021 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants