dockerfile + compose for ol-www0 web_nginx #4725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekarpeles
force-pushed
the
feature/ol-www0
branch
from
602acf8 to
c3894df
Compare
cdrini
reviewed
Mar 31, 2021
mekarpeles
force-pushed
the
feature/ol-www0
branch
from
b7be22c to
f4981ef
Compare
mekarpeles
force-pushed
the
feature/ol-www0
branch
from
f4981ef to
e662109
Compare
mekarpeles
force-pushed
the
feature/ol-www0
branch
from
2720164 to
ddd3509
Compare
cdrini
requested changes
Jun 30, 2021
| @@ -25,7 +25,7 @@ http { | |||
| server_names_hash_bucket_size 64; | |||
| types_hash_bucket_size 64; | |||
|
|
|||
| log_format iacombined '$seed$remote_addr $host $remote_user [$time_local] "$request" $status $body_bytes_sent "$http_referer" "$http_user_agent" $request_time'; | |||
| log_format iacombined '$remote_addr_ipscrub $host $remote_user [$time_local] "$request" $status $body_bytes_sent "$http_referer" "$http_user_agent" $request_time'; | |||
There was a problem hiding this comment.
This is why we no longer need petabox_seed.
There was a problem hiding this comment.
TODO: Remove from olsystem; it's in docker-default.
cdrini
reviewed
Jun 30, 2021
cdrini
reviewed
Jun 30, 2021
docker-compose.production.yml
Outdated
| # sitemap generation (we also need olsystem/etc/cron.d + openlibrary/scripts) | ||
| - /1/var/lib/openlibrary/sitemaps/sitemaps:/sitemaps | ||
| ports: | ||
| - 8080:80 # XXX change to 80!!! |
There was a problem hiding this comment.
Should we change this before merging? Doesn't really matter, I guess.
cdrini
force-pushed
the
feature/ol-www0
branch
from
ed30ab4 to
b7d9e3d
Compare
36 tasks
Co-authored-by: Drini Cami <cdrini@gmail.com>
cdrini
force-pushed
the
feature/ol-www0
branch
2 times, most recently
from
284dd06 to
43f8b2c
Compare
No longer needed with the new nginx binary
- Also use restart: unless-stopped for consistency
cdrini
force-pushed
the
feature/ol-www0
branch
from
43f8b2c to
91de4cf
Compare
This conflicted with out nginx config.
cdrini
approved these changes
Dec 8, 2021
This was referenced Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4252
Closes #4424
Closes #5418
Technical
Testing
Screenshot
Stakeholders