Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

localhost:80 -> web:8080 in openlibrary.yml #4748

Merged
merged 1 commit into from
Mar 6, 2021
Merged

localhost:80 -> web:8080 in openlibrary.yml #4748

merged 1 commit into from
Mar 6, 2021

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Mar 6, 2021 •
edited
Loading

Hotfix. Follow up to #4727 . Causing pages on the dev environment to error trying to hit fake auth servers.

Technical

Testing

Screenshot

Stakeholders

@cdrini cdrini added the Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed] label Mar 6, 2021
@cdrini
Copy link
Collaborator Author

cdrini commented Mar 6, 2021

Auto-merging; breaking local dev environments

@cdrini cdrini merged commit e3dd938 into internetarchive:master Mar 6, 2021
@cdrini cdrini deleted the hotfix/dev-env-errors branch March 6, 2021 20:46
@cdrini
Copy link
Collaborator Author

cdrini commented Mar 6, 2021

@Yashs911 this might have fixed the login issues you were having; can you confirm?

@SaravgiYash
Copy link
Contributor

@Yashs911 this might have fixed the login issues you were having; can you confirm?

@cdrini Yes, Problem solved. Thank You 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdrini @SaravgiYash