Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable vue development builds due to concurrency bug #4749

Merged

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Mar 6, 2021

Apparently these write to the same tmp file :/ The development builds haven't been that useful, so axing them to keep things fast.

This must be merged before our next deploy.

Closes #4733

Technical

Testing

  • docker-compose run --rm home make components doesn't error

Screenshot

Stakeholders

@cclauss

Apparently these write to the same tmp file :/ The development builds haven't been that useful, so axing them to keep things fast.
@cdrini cdrini added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Mar 6, 2021
@cdrini
Copy link
Collaborator Author

cdrini commented Mar 6, 2021

Eh, auto-merging. Blocking deploys, and this will make a lot of this faster make components went from 70s → 26s!

@cdrini cdrini merged commit e8ddec1 into internetarchive:master Mar 6, 2021
@cdrini cdrini deleted the 4733/fix/vue-build-concurrency-bug branch March 6, 2021 21:02
@cclauss cclauss self-assigned this Mar 6, 2021
@cclauss
Copy link
Contributor

cclauss commented Mar 6, 2021

Nice! Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent build bug in node_modules/@vue ... entry-wc.js
2 participants