Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove submit button for observations in book notes modal #4948

Merged

Conversation

jimchamp
Copy link
Collaborator

Closes #

Observations are now POSTed to the server every time an input is checked or unchecked in the book notes modal. A section-level submission indicator is displayed in order to notify patrons of the submission status.

Details sections in observations form are also now open by default.

Technical

Testing

While logged in as a beta-tester:

  1. Navigate to a book page.
  2. Open the book notes modal.
  3. Click on any observation radio button or checkbox.
  4. Ensure that you receive a success message.
  5. Refresh the page.
  6. Open the modal again, ensuring that the previously selected radio button or checkbox is selected.

Screenshot

Successful submission:

ajax_success

Failed submission:

ajax_failure

Note: Timeout added in above examples to better show the pending indicator.

Stakeholders

@mekarpeles
@cdrini

- Add documentation for new methods
- Correct linting errors
- Bump bundlesize
@jimchamp jimchamp added the Theme: Book Tags Issues related to community book tags label Mar 30, 2021
@mekarpeles mekarpeles self-assigned this Apr 6, 2021
@mekarpeles
Copy link
Member

This code is fairly well isolated (outside of the db interactions, which seem fine) and so I'm happy for it to be merged as is. UI seems like an improvement. This feature won't work with js, but that's life.

@mekarpeles mekarpeles merged commit ffe8b27 into internetarchive:master Apr 7, 2021
@jimchamp jimchamp deleted the feature/booknotes-modal-update branch June 9, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Theme: Book Tags Issues related to community book tags
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants