Dropdown Menu for Language #5087
Conversation
SaravgiYash
force-pushed
the
lang-dropdown
branch
from
2dc8a36 to
0d75246
Compare
|
While I haven't pulled down the code and looked at this, I really like the direction here. As we modernize the UI, I am trying to keep the client as light as possible. My intention is that we will lean on JavaScript only for workflows such as the lists feature and editor. These will be completely Vue based. Navigation is something that should work without JavaScript, for a variety of reasons, but mainly because HTML is more future proof because of its backwards compatible nature. Right now, we're currently grappling with upgrading jQuery UI experiences that if taken away would break key components of the site, and I'm keen to avoid that in essential parts of the user interface like this one. I'd also like us to move away from jQuery and show/hide patterns so we don't get stuck into jQuery in the same way. I am in the process of putting together a document explaining a roadmap for the frontend and a guiding philosophy but the approach outlined here definitely sits in well with that! Thanks for trying out different ideas. This one seems to fit in nicely! I urge you to continue it. Experimenting with language and then applying it to all over menus once proved seems like a great approach here. |
I know, we'd need a backend change to support that, but I see that as a necessary part of this solution. |
|
@jdlrobson What should be my next step? I will add the query string parameter. Anything else that I need to do? |
|
@mekarpeles can you advise how i18n should work without javascript, cookies disabled or for local development? |
mekarpeles
added
the
Priority: 3
|
If we merge #5367 then we can remove all the changes related to the mobile view from this PR which will remove most of the duplicate code. |
|
@Yashs911 I think we may be able to move forward with this one since #5367 is merged It looks like some conflicts need to be resolved |
SaravgiYash
force-pushed
the
lang-dropdown
branch
from
0d75246 to
fb83896
Compare
@mekarpeles I have fixed the merge conflict and made the necessary fixes. I have also removed all the changes from the footer section for this PR as now we have IA Bar on Mobile, So do let me know how we want to proceed with the Footer section language list (completely removing it or merging PR 5367) because as you mentioned #5367 is not merged yet |
|
Jest: "global" coverage threshold for statements (19%) not met: 18.81% If someone can guide me on how to fix the above error and pre-commit error |
mekarpeles
added
the
Needs: Submitter Input
Added a dropdown menu for the Language feature.
Screenshot
Desktop:
Mobile:
Stakeholders
@mekarpeles