Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive scripts/20* and scripts/legacy to openlibrary-legacy-code #5823

Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 4, 2021

Closes #1449

Steps taken:

Technical

Testing

Screenshot

Stakeholders

@cclauss cclauss added Affects: Admin/Maintenance Issues relating to support scripts, bots, cron jobs and admin web pages. [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed] labels Nov 4, 2021
@cclauss cclauss changed the title Archive scripts/20* and scripts/legacy to repo openlibrary-legacy-code Archive scripts/20* and scripts/legacy to openlibrary-legacy-code Nov 4, 2021
@cclauss cclauss mentioned this pull request Nov 4, 2021
36 tasks
Copy link
Collaborator

@hornc hornc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss LGTM 👍 -- none of these scripts are or have been in any kind of active use for as long as I have been involved. Many will be one off tasks no longer appropriate, and many of the others will no longer function as originally designed give all the changes which have been made.

I don't seem to have access to the new repo. An old PR of mine that should possibly be added for archiving is https://github.com/internetarchive/openlibrary-bots/pull/37/files , which was never merged into the openlibrary-bots repo. The legacy-repo seems a more appropriate location.

@cclauss
Copy link
Contributor Author

cclauss commented Nov 7, 2021

Sorry for the oversight. I have invited you to be an admin of that repo. Please add any files that you deem appropriate.

@cclauss cclauss merged commit 7d6518e into internetarchive:master Nov 7, 2021
@cclauss cclauss deleted the retire-scripts/20xx-to-legacy-repo branch November 7, 2021 22:15
@cdrini
Copy link
Collaborator

cdrini commented Nov 8, 2021

Woohoo! Double-checked olsystem for all occurrences of scripts, and no references these, so I think we're good :)

cclauss added a commit to cclauss/openlibrary that referenced this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Admin/Maintenance Issues relating to support scripts, bots, cron jobs and admin web pages. [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The scripts/20YY (year) directories should be removed
3 participants