GitHub Action to run pre-commit #5848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
changed the title
21 tasks
cclauss
force-pushed
the
pre-commit-action
branch
from
387cbbf to
c649987
Compare
cclauss
changed the title
cclauss
force-pushed
the
pre-commit-action
branch
from
3f05912 to
1adaabd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtask of #5843
Blocked by #5870Now that we have a pre-commit that runs fast, let's add a GitHub Action that runs it in parallel with our existing JavaScript and Python GitHub Actions. Running this action assures that PRs that are created via the GitHub web UI or other means are tested with the same test that command-line developers use. This could either be a standalone file (this PR) or these commands could be added as a parallel job in the Python Action.
Technical
Testing
Fails because running flake8 inside a Docker container has its downsides.
Screenshot
Stakeholders